Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13380 )
Change subject: [tool-test] scenario for ksck and unusual tserver flags ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/13380/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13380/1//COMMIT_MSG@18 PS1, Line 18: With this test, I verified that the version prior to the above mentioned It's too bad this is so hard to repro, but having a test that'll become flaky if we regress is certainly better than nothing. http://gerrit.cloudera.org:8080/#/c/13380/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13380/1/src/kudu/tools/kudu-tool-test.cc@4538 PS1, Line 4538: // Run tablet servers with a few flags considered unusual by ksck. Could you doc why these custom values are useful? Oh, it's just so that ksck will have something to show in the "unusual flags" section. Is that actually necessary to tickle the race though? I thought the "find unusual flags" calls are made regardless of whether the cluster actually has unusual flags set or not. -- To view, visit http://gerrit.cloudera.org:8080/13380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16cf69b6f7d2fb59014df26601dfc30e124a52ee Gerrit-Change-Number: 13380 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 21 May 2019 20:08:00 +0000 Gerrit-HasComments: Yes
