helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 )
Change subject: [docs] update the upgrade documentation ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/13820/4/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/13820/4/docs/installation.adoc@638 PS4, Line 638: r` > nit: add a comma here Done http://gerrit.cloudera.org:8080/#/c/13820/4/docs/installation.adoc@641 PS4, Line 641: Set the unavailable time for every tablet server to a large value (2x your expected : restart time) by gflag : link:configuration_reference.html#kudu-tserver_follower_unavailable_considered_failed_sec[follower_unavailable_considered_failed_sec]. > nit: maybe reword this part to include more info so we can get rid of the N Done http://gerrit.cloudera.org:8080/#/c/13820/4/docs/installation.adoc@651 PS4, Line 651: /tablets > nit: add backticks here? Done http://gerrit.cloudera.org:8080/#/c/13820/4/docs/installation.adoc@652 PS4, Line 652: - Again raise the `--follower_unavailable_considered_failed_sec` runtime gflag. > nit: maybe clarify this a bit: Done http://gerrit.cloudera.org:8080/#/c/13820/4/docs/installation.adoc@656 PS4, Line 656: Re > nit: lowercase "replicas" Done http://gerrit.cloudera.org:8080/#/c/13820/4/docs/installation.adoc@660 PS4, Line 660: - Restore the default gflag value (5 minutes) for every tablet server. > nit: reword, "Restore the original gflag value of every tablet server (the Done -- To view, visit http://gerrit.cloudera.org:8080/13820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b3e5c549dc05c3388c0b0dd628d205a356da344 Gerrit-Change-Number: 13820 Gerrit-PatchSet: 4 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Priyanka Chheda <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2019 04:52:40 +0000 Gerrit-HasComments: Yes
