Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 )
Change subject: [docs] update the upgrade documentation ...................................................................... Patch Set 3: (5 comments) I added a few comments. I would also be interested in Andrews feedback. He recently started looking at improved rolling restarts and upgrades which includes things like clean shutdowns to reduce startup time, faster startups, etc. http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@a635 PS3, Line 635: I like the idea of documenting how to do a rolling upgrade because we know users are already doing it. However, I think we should prioritize writing upgrade tests that can be run for each release if we are going to encourage it and remove the disclaimer about it being supported. http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@638 PS3, Line 638: - Copy the `kudu-tserver`, `kudu-master` and `kudu` binaries from your build directory. Maybe say something like "Replace the `kudu-server`..." Otherwise it's not clear what you mean by "copy". http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@640 PS3, Line 640: - Set the unavailable time for every tablet server to a large value (2 hours or more) by gflag The 2 hours or more feels a bit arbitrary. Maybe say something like 2x your expected restart time? The example command will still have 2 hours as the sample value. http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@647 PS3, Line 647: wait until it is online Maybe note what a user should a user look at to know it's online? http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@652 PS3, Line 652: restarted tablet servers > "Replicas hosted on restarted tablet servers" This seems like a race against time given the default is 5 minutes. In general an upgrade doesn't take longer than the average restart, so I am not sure setting this config is needed. 3-4-3 replication will prevent to much re-replication, and if this flag is needed for restarts it might need to be set permanently anyway. -- To view, visit http://gerrit.cloudera.org:8080/13820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b3e5c549dc05c3388c0b0dd628d205a356da344 Gerrit-Change-Number: 13820 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Priyanka Chheda <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2019 14:22:19 +0000 Gerrit-HasComments: Yes
