Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 )
Change subject: [docs] update the upgrade documentation ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@635 PS3, Line 635: WARNING: The following upgrade process is only relevant when building from source code. Why is this the case? I guess if you are using thirdparty software to manage Kudu (e.g. Cloudera Manager) it wouldn't be quite right. Bui the steps seem to be fine as long as you have binaries available, regardless of whether or not you built it from source. http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@638 PS3, Line 638: - Copy the `kudu-tserver`, `kudu-master` and `kudu` binaries from your build directory. > Maybe say something like "Replace the `kudu-server`..." Maybe "Place the new `kudu-tserver`, `kudu-master`, and `kudu` binaries into the appropriate Kudu binary directory." http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@647 PS3, Line 647: - Restart a tablet server and wait until it is online, then reset the gflag above to be 7200 again. I think this should be broken down further: - Restart the tablet server. - Again raise the `--follower_unavailable_considered_failed_sec` runtime gflag. - Wait for all tablet replicas on the tablet server to finish bootstrapping by viewing /tablets page in the tablet server web UI. This would help clarify exactly what a user needs to wait for: the user should confirm the health of the tablets on the tablet server before bringing down the next server. http://gerrit.cloudera.org:8080/#/c/13820/3/docs/installation.adoc@651 PS3, Line 651: Make sure the restarted tablet server is already online before resetting the gflag. This is good information to have, but I'd be concerned that it would confuse operators going through these steps since "Make sure the restarted tablet server is already online before resetting the gflag" is already a part of the listed steps, so maybe remove this note? -- To view, visit http://gerrit.cloudera.org:8080/13820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b3e5c549dc05c3388c0b0dd628d205a356da344 Gerrit-Change-Number: 13820 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Priyanka Chheda <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 06:01:18 +0000 Gerrit-HasComments: Yes
