helifu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13820 )

Change subject: [docs] update the upgrade documentation
......................................................................


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@635
PS2, Line 635: for the scenario of compiling from source code.
> "relevant when building from source code".
Done


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@640
PS2, Line 640: 2hours
> "2 hours"
Done


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@640
PS2, Line 640: kudu-tserver
> "tablet server"
Done


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@645
PS2, Line 645: --force
> Shouldn't need this; the flag is tagged as 'runtime'.
Ah, Grant has tagged the follower_unavailable_considered_failed_sec flag as 
runtime.


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@647
PS2, Line 647: kudu-tserver
> "the tablet servers"
Done


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@647
PS2, Line 647: and the gflag above should be reset after every reboot.
> Since step 4 restores the gflag value, do we really need this step?
The 'reset' here means setting to 7200.
========================================
Let me describe it more clearly. If there are 3 tablet servers A, B, C:
1.Set the unavailable time for every kudu-tserver to a large value:
./kudu tserver set_flag A follower_unavailable_considered_failed_sec 7200
./kudu tserver set_flag B follower_unavailable_considered_failed_sec 7200
./kudu tserver set_flag C follower_unavailable_considered_failed_sec 7200

2.Rolling restart kudu-tserver and the gflag above should be reset after every 
reboot:
restart A
./kudu tserver set_flag A follower_unavailable_considered_failed_sec 7200
restart B
./kudu tserver set_flag B follower_unavailable_considered_failed_sec 7200
restart C
./kudu tserver set_flag C follower_unavailable_considered_failed_sec 7200

3.Restore the default gflag value (5 minutes) for every kudu-tserver:
./kudu tserver set_flag A follower_unavailable_considered_failed_sec 300
./kudu tserver set_flag B follower_unavailable_considered_failed_sec 300
./kudu tserver set_flag C follower_unavailable_considered_failed_sec 300


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@649
PS2, Line 649: [NOTE]
> Shouldn't this be just after "Set the unavailable time..." so users underst
The note is used to emphasize the 'reset' is very important, not the first time 
set.


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@651
PS2, Line 651: If the gflag is not reset, kudu-tserver which is restarting 
would be possibly evicted from the cluster.
> "If the unavailable time is not extended, restarted tablet servers could be
Done


http://gerrit.cloudera.org:8080/#/c/13820/2/docs/installation.adoc@654
PS2, Line 654: kudu-master
> "the masters"
Done



--
To view, visit http://gerrit.cloudera.org:8080/13820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3e5c549dc05c3388c0b0dd628d205a356da344
Gerrit-Change-Number: 13820
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <[email protected]>
Gerrit-Reviewer: helifu <[email protected]>
Gerrit-Comment-Date: Wed, 10 Jul 2019 22:48:20 +0000
Gerrit-HasComments: Yes

Reply via email to