Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/13869/11/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/13869/11/src/kudu/client/predicate-test.cc@1145 PS11, Line 1145: > Nit: maybe rename this to something more generic now that it's not just str Done http://gerrit.cloudera.org:8080/#/c/13869/11/src/kudu/client/predicate-test.cc@1165 PS11, Line 1165: case KuduColumnSchema::VARCHAR: > Nit: I would actually reserve the default case for a LOG(FATAL) or some suc that's why I added a DCHECK() but LOG(FATAL) is a better approach, fixed. http://gerrit.cloudera.org:8080/#/c/13869/11/src/kudu/integration-tests/char-itest.cc File src/kudu/integration-tests/char-itest.cc: PS11: > This is fine, though extending client-test would have been fine too (fewer Should I move it there? http://gerrit.cloudera.org:8080/#/c/13869/11/src/kudu/integration-tests/char-itest.cc@68 PS11, Line 68: shared_ptr<KuduSession> session = client_->NewSession(); > May want to explain what's special about the row we're inserting (i.e. what Done http://gerrit.cloudera.org:8080/#/c/13869/11/src/kudu/integration-tests/char-itest.cc@85 PS11, Line 85: for (con > ASSERT_OK Done -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 13 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 14:05:37 +0000 Gerrit-HasComments: Yes
