ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13975 )
Change subject: KUDU-2911: Consider the available space when selecting data dirs for tablets ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13975/1/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/13975/1/src/kudu/fs/data_dirs.cc@1041 PS1, Line 1041: > As a 'score', how about make it float/doube type? Nice, I used to swing in double and int QAQ, because I think the space is much large than tablet number and when it come to that situation each tablet can not have one bytes ordering has no meaning. Anyway double/float is better than int :) http://gerrit.cloudera.org:8080/#/c/13975/1/src/kudu/util/env_util.h File src/kudu/util/env_util.h: http://gerrit.cloudera.org:8080/#/c/13975/1/src/kudu/util/env_util.h@52 PS1, Line 52: reque > Nit: not your fault, could you change it to 'requested_bytes' Done http://gerrit.cloudera.org:8080/#/c/13975/1/src/kudu/util/env_util.h@56 PS1, Line 56: , > nit: , Done -- To view, visit http://gerrit.cloudera.org:8080/13975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194c4965ee64aed728e3b84e684c04d445cbe529 Gerrit-Change-Number: 13975 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Thu, 01 Aug 2019 09:02:50 +0000 Gerrit-HasComments: Yes
