Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13975 )
Change subject: KUDU-2911: Consider the available space when selecting data dirs for tablets ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.h@470 PS3, Line 470: vailable disk space of directory. : // The resulting behavior f > Emmmm, the available space is more clear to understand. Done How will this behave during the creation of a very large table, or at the start of a rereplication storm? That is, how will it behave when we have to create many tablets all at once? Won't it bias all of those tablets' data dir groups towards the emptier data dirs? At least with the status quo, each created tablet affected the power-of-2 choice of the next created tablet (by increasing the number of tablets in the chosen data dirs); here the available disk space won't change until the tablets actually start filling up. -- To view, visit http://gerrit.cloudera.org:8080/13975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194c4965ee64aed728e3b84e684c04d445cbe529 Gerrit-Change-Number: 13975 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2019 04:18:30 +0000 Gerrit-HasComments: Yes
