ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13975 )
Change subject: KUDU-2911: Consider the available space when selecting data dirs for tablets ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.h@470 PS3, Line 470: more avai > We want a higher score though. Maybe reword that to clarify this. Done http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.h@470 PS3, Line 470: vailable disk space of directory. : // The resulting behavior f > It's great that this metric tries to take into account disk space _and_ tab Emmmm, the available space is more clear to understand. Done http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.cc@988 PS3, Line 988: int uuid_idx = (*group_uuid_indices)[i]; > Using EXPIRED_ONLY means that we will only refresh the available bytes if t Thanks a lot. I have restored it to the original. This made me very troubled yesterday and I always think it may be something wrong with the lock. http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.cc@1047 PS3, Line 1047: ata_dirs_, e.firs > nit: would be clearer to name this something like candidates_index_and_scor Done -- To view, visit http://gerrit.cloudera.org:8080/13975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194c4965ee64aed728e3b84e684c04d445cbe529 Gerrit-Change-Number: 13975 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2019 04:03:27 +0000 Gerrit-HasComments: Yes
