ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13975 )
Change subject: Consider the available space when selecting data dirs for blocks. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: http://gerrit.cloudera.org:8080/#/c/13975/3/src/kudu/fs/data_dirs.h@470 PS3, Line 470: (available disk space) / (tablets : // number in the directory) > Here is more complex if tablet were created but only start filling up. Unde Oh I thought about this metrics again. It doesn't work like only use available space when create tablets with data writing soon because this metrics consider the existing tablets and it's not fair for the newly creating tablet. Just like what Andrew Wong said, this metrics doesn't have clear meaning. I think it's not suitable here. But only consider available space can lead to hot directory when create a lot tablets once. I haven't figure out a better method to measure the directory when creating tablets so just hold the original strategy. But I think it's clear for use available space when selecting directory for newly creating blocks :) -- To view, visit http://gerrit.cloudera.org:8080/13975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194c4965ee64aed728e3b84e684c04d445cbe529 Gerrit-Change-Number: 13975 Gerrit-PatchSet: 3 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2019 12:58:49 +0000 Gerrit-HasComments: Yes
