Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: WIP: Create kudu/rebalance subdirectory ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/14110/6/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/14110/6/src/kudu/tools/ksck.h@301 PS6, Line 301: ClusterServerHealth > Can we forward declare these? Done http://gerrit.cloudera.org:8080/#/c/14110/6/src/kudu/tools/ksck.h@613 PS6, Line 613: int table_num_replicas); > nit: spacing Done http://gerrit.cloudera.org:8080/#/c/14110/6/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/14110/6/src/kudu/tools/ksck_results.cc@87 PS6, Line 87: const map<string, : char>& label_by_uuid, > nit: keep these on the same line Done http://gerrit.cloudera.org:8080/#/c/14110/6/src/kudu/tools/placement_policy_util.h File src/kudu/tools/placement_policy_util.h: http://gerrit.cloudera.org:8080/#/c/14110/6/src/kudu/tools/placement_policy_util.h@30 PS6, Line 30: namespace rebalance { : struct ClusterLocalityInfo; : } // namespace rebalance > You can put this in the below kudu namespace. Done -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 6 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 22 Aug 2019 21:40:09 +0000 Gerrit-HasComments: Yes
