Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Move some rebalancing logic from tools to master ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14110/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14110/2//COMMIT_MSG@15 PS2, Line 15: TODO: move tools/placement_policy_util and tools/rebalancer : into master too, so future auto-rebalancer task does not : rely on tools. > Do you think it should be done in parts? ie. pt1 and pt2? If the patch is about moving things around and renaming, it should not be hard to review even if such patch looks big in number of lines. The important thing is not to mix in any semantic changes or other changes in the logic of the code. BTW, is there any other rationale behind the idea of splitting the patch into two pieces except for the concern its size? http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/CMakeLists.txt@48 PS2, Line 48: rebalance_algo.cc > Do you mean adding another directory like kudu/rebalance and moving all thi Eventually, only master is going to use that code (and the kudu CLI will simply make RPC calls to master to perform rebalancing on-demand), I think. But it would not hurt to put it under kudu/rebalance or kudu/rebalancer and use corresponding namespace kudu::rebalance (or kudu::rebalancer), as recommended by Adar. -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Aug 2019 18:34:31 +0000 Gerrit-HasComments: Yes
