Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Move some rebalancing logic from tools to master ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/cluster_status.h File src/kudu/master/cluster_status.h: http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/cluster_status.h@79 PS2, Line 79: boost::optional<int64_t> term, : boost::optional<int64_t> opid_index, : boost::optional<std::string> leader_uuid, : const std::vector<std::string>& voters, : const std::vector<std::string>& non_voters) nit: given the renames, be sure to fix any spacing issues this may have caused. http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/cluster_status.h@119 PS2, Line 119: // Originally named KsckServerHealth. nit: remove and maybe just mention the rename in the commit message. Same with other renamed classes. http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/tools/ksck-test.cc@67 PS2, Line 67: using kudu::master::ClusterConsensusConfigType; : using kudu::master::ClusterConsensusState; : using kudu::master::ClusterConsensusStateMap; : using kudu::master::ClusterReplicaSummary; : using kudu::master::ClusterServerHealth; : using kudu::master::ClusterServerHealthSummary; : using kudu::master::ClusterTableSummary; : using kudu::master::ClusterTabletSummary; : : using server::GetFlagsResponsePB; : using std::ostringstream; : using std::shared_ptr; : using std::static_pointer_cast; : using std::string; : using std::unordered_map; : using std::vector; : using strings::Substitute; : using tablet::TabletDataState; : nit: you can drop the 'kudu::' prefix, or move all of these out of the namespaces, eg: using kudu::master::Cluster... ... using kudu::server::GetFlagsResponsePB; using kudu::tablet::TabletDataState; using std::ostringstream; using std::... using strings::Substitute; which is nice because it makes the namespaces even more explicit. http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/tools/ksck_results.h File src/kudu/tools/ksck_results.h: http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/tools/ksck_results.h@114 PS2, Line 114: // master_summaries : // tserver_summaries : // master_uuids : // master_consensus_conflict : // master_consensus_state_map : // tablet_summaries : // table_summaries nit: remove this? -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Aug 2019 20:07:04 +0000 Gerrit-HasComments: Yes
