Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc@228 PS7, Line 228: if (!FLAGS_logtostderr) { > Grant, I was in the assumption that stderrthreshold is not safe to publish Why are you worried it's unsafe? FWIW stderrthreshold is already being published. I agree the name is not the most clear, but this feature is really only useful for the docker images, so it shouldn't be common for users outside of that hardcoded instance. -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 7 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2019 19:24:26 +0000 Gerrit-HasComments: Yes
