Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc@228 PS7, Line 228: if (!FLAGS_logtostderr) { > I have updated the PR with creating a new flag(not tested yet), but I found I agree using the built-in flags makes more sense than adding new ones. I'd prefer we published --stderrthreshold though; if it obsoletes --alsologtostderr, there's no guarantee that the latter will stick around in future glog releases. I think Grant's point is just that you should carefully audit the codebase to make sure we find (and update) all instances where we assume that e.g. if --logtostderr is set we aren't logging to files. That includes this file as well as various usages of FLAGS_logtostderr. -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 7 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2019 04:31:05 +0000 Gerrit-HasComments: Yes
