Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/14140/10/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/14140/10/docker/kudu-entrypoint.sh@59 PS10, Line 59: --logtostderr_and_logdir=true \ Based on the flag discussion, this could be set to --stderrthreshold=0 http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc@228 PS7, Line 228: // complex logic that glog uses to guess at a temporary dir. > basically, setting true for alsologtostderr enables logging to both stderr I think instead of adding a new kudu only flag, the suggestion is to leverage `--stderrthreshold` and publish that flag. It looks like we already do that as an advanced flag in flags.cc and it shows up in our documentation here: https://kudu.apache.org/docs/configuration_reference.html#kudu-master_stderrthreshold I didn't know this flag existed, but I added `--stderrthreshold=0` to the quickstart.yml entries and it looks like it works correctly. Logging to both stderr and the default log_dir. The logs web ui also works. -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 10 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2019 15:12:14 +0000 Gerrit-HasComments: Yes
