Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc@228 PS7, Line 228: // complex logic that glog uses to guess at a temporary dir. > There is some logic that may need to be updated to handle logging both plac basically, setting true for alsologtostderr enables logging to both stderr and log dir!. as the team thinks that alsologtostderr may get deprecated from glog lib, so I have added a new flag! I have tested through docker and added changes to PR also. I could write a unit test case something like this https://github.com/apache/kudu/blob/master/src/kudu/integration-tests/log-rolling-itest.cc#L46 but not sure how to catch the stderr logs, as it controlled by glog lib. http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc@228 PS7, Line 228: // complex logic that glog uses to guess at a temporary dir. > I agree using the built-in flags makes more sense than adding new ones. I'd Adar, ended up adding a new flag in logging.cc, which basically sets the glog field log threshold to INFO when logtostderr_and_logdir set true. otherwise, previous logic is retained. -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 10 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2019 07:30:10 +0000 Gerrit-HasComments: Yes
