Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14128/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14128/3//COMMIT_MSG@13 PS3, Line 13: check whether a table is balanced or not by thirdparty monitor system. > When we use rebalancer to check per-table balance status of a cluster, we h Thanks, that's useful to know. Maybe you can find a way to incorporate this explanation into your commit message? http://gerrit.cloudera.org:8080/#/c/14128/4/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14128/4/src/kudu/util/metrics.h@737 PS4, Line 737: // Invalidate 'm_epoch_', then this metric is invisible until its value changed. Nit: "Invalidate 'm_epoch_', causing this metric to be invisible until its value changes." http://gerrit.cloudera.org:8080/#/c/14128/2/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/14128/2/src/kudu/util/metrics.cc@479 PS2, Line 479: // metrics, we should keep them around until the next poll. > It's not the only kind, we may perform more merge types. Hmm, I don't see this change done: I still see just the one static metric prototype for merging tablet entities. -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2019 20:20:05 +0000 Gerrit-HasComments: Yes
