Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14128/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14128/5/src/kudu/master/catalog_manager.cc@276 PS5, Line 276: METRIC_DEFINE_gauge_size(table, merged_table_entities_count, : "Entities Count Merged From", : kudu::MetricUnit::kEntries, : "When enabled metrics merge by some entity attribute, " : "and this is a merged entity, this metric identify " : "how many entities it merged from."); Instead of adding METRIC_DEFINE_gauge_size to every place where METRIC_DEFINE_entity is used, could you modify the macro definition for METRIC_DEFINE_entity to also call METRIC_DEFINE_gauge_size? -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 04 Sep 2019 05:56:55 +0000 Gerrit-HasComments: Yes
