Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/14128/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14128/7//COMMIT_MSG@14 PS7, Line 14: In Kudu, when we want to check whether tables are balanced or not on : tservers, and how many replicas distributed > Could you add more details on this? I think that might be a good how-to ex Done http://gerrit.cloudera.org:8080/#/c/14128/7/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/14128/7/src/kudu/tablet/tablet.cc@234 PS7, Line 234: InstantiateHidden(metric_entity_, 1); : } > Would it make sense to combine these two calls into a new method, something InstantiateHidden() would be better I think, because it will appear either be merged or updated. Done http://gerrit.cloudera.org:8080/#/c/14128/7/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14128/7/src/kudu/util/metrics.h@265 PS7, Line 265: "Count of entities merged together when entities are " \ : "merged by common attribute value."); : > Reword as "Count of entities merged together when entities are merged by co Done -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 06 Sep 2019 03:07:32 +0000 Gerrit-HasComments: Yes
