Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/14128/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14128/7//COMMIT_MSG@14 PS7, Line 14: We can use this information to check whether a table is balanced or : not by thirdparty monitor system efficiently Could you add more details on this? I think that might be a good how-to example for people who might be interested in using this newly introduced functionality (maybe, even with other metrics). http://gerrit.cloudera.org:8080/#/c/14128/7/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/14128/7/src/kudu/tablet/tablet.cc@234 PS7, Line 234: Instantiate(metric_entity_, 1) : ->InvalidateEpoch(); Would it make sense to combine these two calls into a new method, something like InstantiateHidden() / InstantiateAppearOnMerge() / InstantiateAppearOnUpdate() or alike? If Metric::InvalidateEpoch() is not used anywhere else, it may be possible to keep it a private. -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2019 23:56:41 +0000 Gerrit-HasComments: Yes
