Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 )
Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc@328 PS2, Line 328: NO_FATALS(send_req_check_failed("must contain tserver state change")); IMHO, these error messages should be defined as string constants somewhere, because they are used twice in the code base. -- To view, visit http://gerrit.cloudera.org:8080/14221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d565bd745507f2511b91a96d2d446240c5406b5 Gerrit-Change-Number: 14221 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Sep 2019 17:49:35 +0000 Gerrit-HasComments: Yes
