Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 )
Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/master.proto@988 PS2, Line 988: AuthorizeSuperUser nit: Can you mention this requires super user privilege, as it is for administrative purpose, in the commit message. http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc@339 PS2, Line 339: ChangeTServerState Do we need to check the RPC is a no op when transiting tserver to maintenance mode if the tserver is already in maintenance mode? -- To view, visit http://gerrit.cloudera.org:8080/14221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d565bd745507f2511b91a96d2d446240c5406b5 Gerrit-Change-Number: 14221 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Sep 2019 19:39:46 +0000 Gerrit-HasComments: Yes
