Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 )
Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Carrying forward the +2 since I only rebased. http://gerrit.cloudera.org:8080/#/c/14221/4/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/14221/4/src/kudu/master/master_service.cc@236 PS4, Line 236: rpc->RespondFailure(s); : return; : } : rpc->RespondSuccess(); > nit: maybe, release the lock (ScopedLeaderSharedLock) because it's not need I'm not sure that's the case -- we would want to ensure that we're leader while sending the RPC, no? It's a bit fuzzy, IMO, but we don't drop the lock anywhere else, so I think I'll keep it here for now. -- To view, visit http://gerrit.cloudera.org:8080/14221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d565bd745507f2511b91a96d2d446240c5406b5 Gerrit-Change-Number: 14221 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Sep 2019 22:59:20 +0000 Gerrit-HasComments: Yes
