Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 )
Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/master.proto@825 PS2, Line 825: // The tserver UUID on which to apply the state change. Nit: add an empty line before. http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/master_service.cc@202 PS2, Line 202: if (!req->has_change()) { FWIW, the default value of a protobuf enum is its first possible value. http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc@328 PS2, Line 328: NO_FATALS(send_req_check_failed("must contain tserver state change")); > I thought tests in that regard should be independent from the source that e I don't think we have a strict convention here, but I agree with Alexey that decoupling the test from the implementation generally makes sense. -- To view, visit http://gerrit.cloudera.org:8080/14221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d565bd745507f2511b91a96d2d446240c5406b5 Gerrit-Change-Number: 14221 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 13 Sep 2019 04:10:33 +0000 Gerrit-HasComments: Yes
