Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 )
Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14220/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14220/2//COMMIT_MSG@9 PS2, Line 9: replica movement nit: placing replicas ? http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_manager.h File src/kudu/master/ts_manager.h: http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_manager.h@118 PS2, Line 118: const std::shared_ptr<TSDescriptor>& ts nit: is passing reference to shared_ptr is crucial here? What if pass simply const TSDescriptor& instead? http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@267 PS2, Line 267: TEST_F(TServerStateTest, MaintenanceModeDoesntPlaceReplicas) { I hope we have the coverage for the re-replication case in some other test scenario, right? http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@305 PS2, Line 305: ASSERT_TRUE(s.IsInvalidArgument()); nit: add << s.ToString() to have the details on the unexpected status reported if this assertion triggers http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@307 PS2, Line 307: } Does it make sense to verify that after moving the server out of the maintenance mode replicas are placed on the server upon creating a table? -- To view, visit http://gerrit.cloudera.org:8080/14220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc3ca41a3b3c8625bec0470e9604df86e91b4952 Gerrit-Change-Number: 14220 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 12 Sep 2019 18:36:20 +0000 Gerrit-HasComments: Yes
