Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 )
Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@140 PS2, Line 140: CreateTableResponsePB resp; : RpcController rpc; : CreateTableRequestPB req; Nit: reorder so the req/resp follow one another? http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@145 PS2, Line 145: RETURN_NOT_OK(SchemaToPB(schema, req.mutable_schema())); Nit: inline GetSimpleTestSchema() here? -- To view, visit http://gerrit.cloudera.org:8080/14220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc3ca41a3b3c8625bec0470e9604df86e91b4952 Gerrit-Change-Number: 14220 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 13 Sep 2019 04:05:28 +0000 Gerrit-HasComments: Yes
