Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 )
Change subject: KUDU-2069 p2: stop placement onto servers in maintenance mode ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/14220/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14220/2//COMMIT_MSG@9 PS2, Line 9: placement of rep > nit: placing replicas ? Done http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_manager.h File src/kudu/master/ts_manager.h: http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_manager.h@86 PS2, Line 86: > nit: replica placement? Done http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_manager.h@118 PS2, Line 118: mode). > nit: is passing reference to shared_ptr is crucial here? What if pass simp Done http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@140 PS2, Line 140: // replication factor, and a single partition. : Status CreateTable(const string& table_name) { : CreateTableResponsePB res > Nit: reorder so the req/resp follow one another? Done http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@145 PS2, Line 145: req.set_name(table_name); > Nit: inline GetSimpleTestSchema() here? Done http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@267 PS2, Line 267: // Test that tablet servers that are in maintenance mode don't get tablet > I hope we have the coverage for the re-replication case in some other test Right, there is a test case ensuring that we don't re-replicate failed replicas when that tablet server is in maintenance mode. See https://gerrit.cloudera.org/c/14222/2/src/kudu/integration-tests/maintenance_mode-itest.cc http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@305 PS2, Line 305: Status s = CreateTable("sad-table"); > nit: add << s.ToString() to have the details on the unexpected status repor Done http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@307 PS2, Line 307: ASSERT_STR_CONTAINS(s.ToString(), "not enough live tablet servers"); > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/14220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc3ca41a3b3c8625bec0470e9604df86e91b4952 Gerrit-Change-Number: 14220 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Sep 2019 20:47:19 +0000 Gerrit-HasComments: Yes
