Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 )
Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_manager.h File src/kudu/master/ts_manager.h: http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_manager.h@86 PS2, Line 86: placement nit: replica placement? http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14220/2/src/kudu/master/ts_state-test.cc@307 PS2, Line 307: } > Does it make sense to verify that after moving the server out of the mainte +1 -- To view, visit http://gerrit.cloudera.org:8080/14220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc3ca41a3b3c8625bec0470e9604df86e91b4952 Gerrit-Change-Number: 14220 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 12 Sep 2019 19:09:07 +0000 Gerrit-HasComments: Yes
