Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14473 )
Change subject: www: convert dashboards and threads to mustache templates ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14473/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14473/1//COMMIT_MSG@9 PS1, Line 9: While I was there I added "fancy tables" to /threadz. Could you post a snippet of now it looks like now? Also, what about /tablets? http://gerrit.cloudera.org:8080/#/c/14473/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/14473/1/src/kudu/util/thread.cc@388 PS1, Line 388: vector<ThreadDescriptor> descriptors_to_print; Is this needed? BTW, in prior approach lock was only held to make a snapshot of the thread descriptors, etc. The idea was to avoid expensive IO (writing into ostringstream) while holding the lock, because it might hamper adding information on spawned threads into the thread registry. How is expensive to work with EasyJson in that regard? http://gerrit.cloudera.org:8080/#/c/14473/1/www/threadz.mustache File www/threadz.mustache: http://gerrit.cloudera.org:8080/#/c/14473/1/www/threadz.mustache@28 PS1, Line 28: (s) nit here and below: '(s)' stands for seconds here, right? Maybe, separate '(s)' with space from the prefix. Additionally, maybe replace '(s)' with '(seconds)'? -- To view, visit http://gerrit.cloudera.org:8080/14473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb97a9e3bbefb8ee607638af6e069959c5354225 Gerrit-Change-Number: 14473 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 17 Oct 2019 00:32:48 +0000 Gerrit-HasComments: Yes
