Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14473 )
Change subject: www: miscellaneous mustache updates ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14473/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14473/1//COMMIT_MSG@9 PS1, Line 9: 1. Converted /dashboards and /threadz into mustache t > Could you post a snippet of now it looks like now? Added link to screenshots. /tablets was already mustached, but I'll mention the change I made to it. http://gerrit.cloudera.org:8080/#/c/14473/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/14473/1/src/kudu/util/thread.cc@388 PS1, Line 388: thr["user_sec"] = static_cast<double>(stats.us > Is this needed? That's a fair criticism, and I think the issue isn't so much in EasyJson or ostringstream as it is with the behavior of PrintThreadDescriptorRow, which does several syscalls on procfs. I'll fix this. http://gerrit.cloudera.org:8080/#/c/14473/1/www/threadz.mustache File www/threadz.mustache: http://gerrit.cloudera.org:8080/#/c/14473/1/www/threadz.mustache@28 PS1, Line 28: (s > nit here and below: '(s)' stands for seconds here, right? Maybe, separate Separated with a space. When repeated three times, '(seconds)' makes the table quite wide, so I'm punting on that. -- To view, visit http://gerrit.cloudera.org:8080/14473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb97a9e3bbefb8ee607638af6e069959c5354225 Gerrit-Change-Number: 14473 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 17 Oct 2019 06:43:08 +0000 Gerrit-HasComments: Yes
