Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14473 )
Change subject: www: miscellaneous mustache updates ...................................................................... www: miscellaneous mustache updates 1. Converted /dashboards and /threadz into mustache templates. In /threadz, I tried to defer as much work as possible outside the lock, since it must be taken in write mode to create a new thread. While I was there I added "fancy tables" to /threadz; /dashboards remains visually unchanged. 2. In /tablets, changed the handling of tablet links. In doing so, all links (except for the main template) are now in templates instead of in code. Screenshots: https://imgur.com/a/AOTQuH4 Change-Id: Idb97a9e3bbefb8ee607638af6e069959c5354225 Reviewed-on: http://gerrit.cloudera.org:8080/14473 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tserver/tserver_path_handlers.cc M src/kudu/tserver/tserver_path_handlers.h M src/kudu/util/thread.cc A www/dashboards.mustache M www/kudu.js M www/tablets.mustache A www/threadz.mustache 7 files changed, 192 insertions(+), 107 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idb97a9e3bbefb8ee607638af6e069959c5354225 Gerrit-Change-Number: 14473 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
