Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 )
Change subject: KUDU-2986 p2: hide the live row count of table metrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14601/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14601/1/src/kudu/master/catalog_manager.cc@5592 PS1, Line 5592: metrics_->HideLiveRowCount(metric_entity_); When old partitions have been dropped, the metric should not be hidden, right? -- To view, visit http://gerrit.cloudera.org:8080/14601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533 Gerrit-Change-Number: 14601 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2019 10:51:52 +0000 Gerrit-HasComments: Yes
