Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 )
Change subject: KUDU-2986 p2: hide the live row count of table metrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14601/1/src/kudu/master/table_metrics.cc File src/kudu/master/table_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14601/1/src/kudu/master/table_metrics.cc@65 PS1, Line 65: METRIC_live_row_count.InstantiateInvalid(entity, 0); > It seems that neither InstantiateInvalid() nor InvalidateEpoch() is the bes Don't we faithfully preserve the last ReportedTabletStatsPB for each tablet in the catalog manager (in TabletInfos), regardless of whether the table supports live row counting or not? So when the last "legacy" tablet disappears, couldn't we immediately determine the aggregate live row count based on information already available to the master? -- To view, visit http://gerrit.cloudera.org:8080/14601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533 Gerrit-Change-Number: 14601 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2019 08:28:49 +0000 Gerrit-HasComments: Yes
