Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 )
Change subject: KUDU-2986 p2: hide the live row count of table metrics ...................................................................... Patch Set 1: (1 comment) I think Alexey is also going to help keep track of all the extant bugs related to live row counting, so I've cc'ed him on this review. http://gerrit.cloudera.org:8080/#/c/14601/1/src/kudu/master/table_metrics.cc File src/kudu/master/table_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14601/1/src/kudu/master/table_metrics.cc@65 PS1, Line 65: METRIC_live_row_count.InstantiateInvalid(entity, 0); Why this and not on_disk_size->InvalidateEpoch()? -- To view, visit http://gerrit.cloudera.org:8080/14601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533 Gerrit-Change-Number: 14601 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2019 23:29:17 +0000 Gerrit-HasComments: Yes
