Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14604
to look at the new patch set (#2).
Change subject: [util] Fix comment of faststring
......................................................................
[util] Fix comment of faststring
1. Under any case, capacity() is larger than the data length.
If the current length is shorter than kInitialCapacity,
after call shrink_to_fit(), capacity() will go down to
kInitialCapacity.
2. The caller must be responsible for releaseing the pointer
release() returns.
This commit also fixes the argument to call `GrowByAtLeast()`,
passing the argument to be an exact space to expand.
Note: If the capacity needs to grow, it still expand by
at least 50% each time.
Change-Id: Ie4bd4f31216fdf5cfbf70526f1358824fbda225a
---
M src/kudu/util/faststring.h
1 file changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14604/2
--
To view, visit http://gerrit.cloudera.org:8080/14604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4bd4f31216fdf5cfbf70526f1358824fbda225a
Gerrit-Change-Number: 14604
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
