Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 )
Change subject: [util] Fix comment of faststring ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14604/1/src/kudu/util/faststring.h File src/kudu/util/faststring.h: http://gerrit.cloudera.org:8080/#/c/14604/1/src/kudu/util/faststring.h@239 PS1, Line 239: GrowByAtLeast(len_ + count - capacity_); > This is a bit weird. I checked several failed test cases, they are all in t There were also a lot of non-Python failures: http://dist-test.cloudera.org/job?job_id=jenkins-slave.1572531693.17453 Here's one. Basically, the new behavior of GrowByAtLeast can sometimes _shrink_ a faststring. F1031 14:22:13.662508 4259 faststring.cc:39] Check failed: newcapacity >= capacity_ (2 vs. 32) *** Check failure stack trace: *** @ 0x7fab9fccf62d google::LogMessage::Fail() at ??:0 @ 0x7fab9fcd164c google::LogMessage::SendToLog() at ??:0 @ 0x7fab9fccf189 google::LogMessage::Flush() at ??:0 @ 0x7fab9fcd1fdf google::LogMessageFatal::~LogMessageFatal() at ??:0 @ 0x7faba0d9d731 kudu::faststring::GrowArray() at ??:0 @ 0x7fabaf4c70df kudu::faststring::append() at ??:0 @ 0x7faba1c89b89 kudu::KeyEncoderTraits<>::EncodeWithSeparators() at ??:0 @ 0x7faba1c2a8d8 kudu::EncodedKeyBuilder::AddColumnKey() at ??:0 @ 0x7faba1c2a474 kudu::EncodedKey::FromContiguousRow() at ??:0 @ 0x7fabac3fb8f5 kudu::tablet::RowSetKeyProbe::RowSetKeyProbe() at ??:0 @ 0x7fabac3c5ca0 kudu::tablet::Tablet::AcquireLockForOp() at ??:0 @ 0x7fabac3c553f kudu::tablet::Tablet::AcquireRowLocks() at ??:0 @ 0x7fabac4fa751 kudu::tablet::WriteTransaction::Prepare() at ??:0 @ 0x7fabac4e21c1 kudu::tablet::TransactionDriver::Prepare() at ??:0 @ 0x7fabac4e0a56 kudu::tablet::TransactionDriver::PrepareTask() at ??:0 @ 0x7fabac4ec4b6 kudu::internal::InvokeHelper<>::MakeItSo() at ??:0 @ 0x7fabac4ec1ab kudu::internal::Invoker<>::Run() at ??:0 @ 0x7faba0f4ae7e kudu::ThreadPool::DispatchThread() at ??:0 @ 0x7faba0f67a23 boost::_bi::bind_t<>::operator()() at ??:0 @ 0x7faba45438ac boost::function0<>::operator()() at ??:0 @ 0x7faba0f2edfb kudu::Thread::SuperviseThread() at ??:0 @ 0x7faba957a184 start_thread at ??:0 @ 0x7fab9c8e6ffd clone at ??:0 -- To view, visit http://gerrit.cloudera.org:8080/14604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4bd4f31216fdf5cfbf70526f1358824fbda225a Gerrit-Change-Number: 14604 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 01 Nov 2019 05:44:50 +0000 Gerrit-HasComments: Yes
