[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 )
Change subject: [util] Fix comment of faststring ...................................................................... Patch Set 3: (3 comments) > Patch Set 3: > > (3 comments) > > Could you add a few tests to faststring-test that verify the growth behavior > you want? Should be as simple as a few append() calls mixed in with > verifications of length() and capacity(). I will add the test. http://gerrit.cloudera.org:8080/#/c/14604/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14604/3//COMMIT_MSG@9 PS3, Line 9: larger than > Not to be overly pedantic, "greater than or equal to" is more accurate, rig Done http://gerrit.cloudera.org:8080/#/c/14604/3//COMMIT_MSG@13 PS3, Line 13: releaseing > Nit: releasing Done http://gerrit.cloudera.org:8080/#/c/14604/3//COMMIT_MSG@20 PS3, Line 20: This > this Done -- To view, visit http://gerrit.cloudera.org:8080/14604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4bd4f31216fdf5cfbf70526f1358824fbda225a Gerrit-Change-Number: 14604 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 01 Nov 2019 08:29:37 +0000 Gerrit-HasComments: Yes
