Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 )
Change subject: [util] Fix comment of faststring ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14604/4/src/kudu/util/faststring-test.cc File src/kudu/util/faststring-test.cc: http://gerrit.cloudera.org:8080/#/c/14604/4/src/kudu/util/faststring-test.cc@93 PS4, Line 93: std::string Could you add "#include <string>", "using std::string", then remove these std:: prefixes? -- To view, visit http://gerrit.cloudera.org:8080/14604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4bd4f31216fdf5cfbf70526f1358824fbda225a Gerrit-Change-Number: 14604 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 01 Nov 2019 09:03:16 +0000 Gerrit-HasComments: Yes
