Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14644 )
Change subject: [cfile] Improve the hash function of pair<DataType, EncodingType> ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14644/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14644/2//COMMIT_MSG@13 PS2, Line 13: For example, the hash values of <UINT32=4, BIT_SHUFFLE=6> : and <INT32=5, PLAIN_ENCODING=1> are both equal to `100101` May be I'm missing something obvious, but I'm afraid I don't see collision. Don't see chance of overflow with 32-bit size_t as well. $ calc "(4 + 31) ^ 6" 1838265625 $ calc "(5 + 31) ^ 1" 36 -- To view, visit http://gerrit.cloudera.org:8080/14644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id141c51147ae674b9bee3016026a0b91cb76b5aa Gerrit-Change-Number: 14644 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Nov 2019 18:38:32 +0000 Gerrit-HasComments: Yes
