[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/14644 )
Change subject: [cfile] Improve the hash function of pair<DataType, EncodingType> ...................................................................... Patch Set 3: > Patch Set 3: > > did you see this being a perf hotspot anywhere? if so we could use a minimal > perfect hash here, but we should also understand why we're calling into it in > any hot path No. I modified this, just because I found that the hash functor may have hash collisions when reading the code. -- To view, visit http://gerrit.cloudera.org:8080/14644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id141c51147ae674b9bee3016026a0b91cb76b5aa Gerrit-Change-Number: 14644 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2019 08:50:18 +0000 Gerrit-HasComments: No
