Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14644 )
Change subject: [cfile] Improve the hash function of pair<DataType, EncodingType> ...................................................................... [cfile] Improve the hash function of pair<DataType, EncodingType> In the original implementation, because `DataType` part and `EncodingType` part will use the same bits, it is easy to have hash collisions. For example, the hash values of <UINT32=4, BIT_SHUFFLE=6> and <INT32=5, PLAIN_ENCODING=1> are both equal to `100101` This change also removed an unused member from `TypeEncodingTraits` Change-Id: Id141c51147ae674b9bee3016026a0b91cb76b5aa Reviewed-on: http://gerrit.cloudera.org:8080/14644 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/cfile/type_encodings.cc 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id141c51147ae674b9bee3016026a0b91cb76b5aa Gerrit-Change-Number: 14644 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
