Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14644 )
Change subject: [cfile] Improve the hash function of pair<DataType, EncodingType> ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14644/2/src/kudu/cfile/type_encodings.cc File src/kudu/cfile/type_encodings.cc: http://gerrit.cloudera.org:8080/#/c/14644/2/src/kudu/cfile/type_encodings.cc@208 PS2, Line 208: return (pair.first << 5) + pair.second; > The hash functor in gutil/hash.h is a more general version. Although it sup I don't have a strong opinion on this. -- To view, visit http://gerrit.cloudera.org:8080/14644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id141c51147ae674b9bee3016026a0b91cb76b5aa Gerrit-Change-Number: 14644 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 07 Nov 2019 03:57:36 +0000 Gerrit-HasComments: Yes
