Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14354 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 2 ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG@22 PS11, Line 22: [ RUN ] CharUtilTest.StressTestUtf8 : [ OK ] CharUtilTest.StressTestUtf8 (10599 ms) Looks like this got slower? Why? http://gerrit.cloudera.org:8080/#/c/14354/11/src/kudu/util/char_util-test.cc File src/kudu/util/char_util-test.cc: http://gerrit.cloudera.org:8080/#/c/14354/11/src/kudu/util/char_util-test.cc@97 PS11, Line 97: Slice data; : : data = "ááááááááááááááááááááááááááááááááaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; Combine? http://gerrit.cloudera.org:8080/#/c/14354/9/src/kudu/util/char_util.cc File src/kudu/util/char_util.cc: PS9: > We should ensure that these instructions are present on the CPU in our mach Think you missed this. -- To view, visit http://gerrit.cloudera.org:8080/14354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a491157dd5c8b4815030bbda921a0afc0bafd28 Gerrit-Change-Number: 14354 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Nov 2019 06:19:02 +0000 Gerrit-HasComments: Yes
