Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14354 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 2 ...................................................................... Patch Set 14: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG@22 PS11, Line 22: [ RUN ] CharUtilTest.StressTestUtf8 : [ OK ] CharUtilTest.StressTestUtf8 (9285 ms) > Out of curiosity I checked what happens if we can use AVX instructions, her Well, let's not lose sight of the broader context: this functionality micro-optimizes writing VARCHAR data to Kudu. Given that we'd expect most folks to use STRING and not VARCHAR, perhaps we should timebox this endeavour. Personally I'd optimize for UTF-8 over ASCII but it probably doesn't matter much either way. http://gerrit.cloudera.org:8080/#/c/14354/14/src/kudu/util/char_util.cc File src/kudu/util/char_util.cc: PS14: New indentation doesn't look right; the bodies of the if/else-if shouldn't align with the condition, they should align with two-chars-after-the-brace. -- To view, visit http://gerrit.cloudera.org:8080/14354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a491157dd5c8b4815030bbda921a0afc0bafd28 Gerrit-Change-Number: 14354 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Nov 2019 06:55:04 +0000 Gerrit-HasComments: Yes
