Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14354 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 2 ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG@22 PS11, Line 22: [ RUN ] CharUtilTest.StressTestUtf8 : [ OK ] CharUtilTest.StressTestUtf8 (9285 ms) > Well, let's not lose sight of the broader context: this functionality micro Yep definitely don't want to spend too much more time optimizing this, but also didn't want to leave it too slow. Replacing SSE4.1 with AVX instead of adding it as yet another branch has roughly the same speed-up on the fast path with a smaller overhead to the slow path btw: [ RUN ] CharUtilTest.StressTestUtf8 [ OK ] CharUtilTest.StressTestUtf8 (10111 ms) [ RUN ] CharUtilTest.StressTestAscii [ OK ] CharUtilTest.StressTestAscii (412 ms) Anyway, do you think it's worth starting a discussion on dev@ about AVX in general? AVX has been present since Sandy Bridge (introduced in 2011) on virtually all x86 CPUs and the SSE4.2 dependency rules out non-x86 CPUs anyway. http://gerrit.cloudera.org:8080/#/c/14354/14/src/kudu/util/char_util.cc File src/kudu/util/char_util.cc: PS14: > New indentation doesn't look right; the bodies of the if/else-if shouldn't Done -- To view, visit http://gerrit.cloudera.org:8080/14354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a491157dd5c8b4815030bbda921a0afc0bafd28 Gerrit-Change-Number: 14354 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Nov 2019 13:28:10 +0000 Gerrit-HasComments: Yes
