Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14354 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 2 ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG@22 PS11, Line 22: [ RUN ] CharUtilTest.StressTestUtf8 : [ OK ] CharUtilTest.StressTestUtf8 (9285 ms) > yeah maybe allow setting it on SetSliceCopy? I tried having a fallback fast Out of curiosity I checked what happens if we can use AVX instructions, here are the results: 8, 16 and 32 byte fast paths (unaligned): [ RUN ] CharUtilTest.StressTestUtf8 [ OK ] CharUtilTest.StressTestUtf8 (11544 ms) [ RUN ] CharUtilTest.StressTestAscii [ OK ] CharUtilTest.StressTestAscii (399 ms) I was wondering if I should leave the AVX stuff in behind #ifdef __AVX__ and maybe start a discussion on dev@ about supporting AVX with an optional cmake flag. -- To view, visit http://gerrit.cloudera.org:8080/14354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a491157dd5c8b4815030bbda921a0afc0bafd28 Gerrit-Change-Number: 14354 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Nov 2019 14:28:58 +0000 Gerrit-HasComments: Yes
