Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java File java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java: http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@22 PS10, Line 22: import java.util.HashMap; : import java.util.Map; Don't need? Could you check the rest of the includes? http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@77 PS10, Line 77: /** : * Returns time taken between a scan rpc request being accepted and when it was handled in : * nanoseonds : * @return long representing the time taken between a scan rpc request being accepted and when : * it was handled in nanoseonds : */ : public long getQueueDurationNanos() { : return queueDurationNanos; : } : : /** : * Returns total time taken for a scan rpc request to complete in nanoseconds : * @return long representing the time taken for a scan rpc request to complete in nanoseconds : */ : public long getTotalDurationNanos() { : return totalDurationNanos; : } : These two talk about "scan rpcs", but the values themselves are additive across RPCs, right? We should update the Javadoc to reflect that. http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java: http://gerrit.cloudera.org:8080/#/c/8375/10/java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java@115 PS10, Line 115: assertTrue("cpu_user_nanos > 0", : resourceMetrics.getCpuUserNanos() > 0L); : assertTrue("cpu_system_nanos > 0", : resourceMetrics.getCpuSystemNanos() > 0L); Like with client-test, it seems like this isn't guaranteed to be true. -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 10 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2019 22:32:46 +0000 Gerrit-HasComments: Yes
