[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/8375/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8375/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@311 PS8, Line 311: > Can do this inline on L225 and then declare resourceMetrics final. Done http://gerrit.cloudera.org:8080/#/c/8375/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@464 PS8, Line 464: return this.resourceMetrics; : } > Got some trailing whitespace here. Done http://gerrit.cloudera.org:8080/#/c/8375/8/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java File java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java: http://gerrit.cloudera.org:8080/#/c/8375/8/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@72 PS8, Line 72: */ : public long getBytesRead() { : return bytesRead; : } : : /** > Do we really want to use protobuf reflection here? Seems like the list of f I removed the map and stored the individual metrics as long fields. http://gerrit.cloudera.org:8080/#/c/8375/8/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/8375/8/src/kudu/tserver/scanners.h@444 PS8, Line 444: // object pointed to by 'cpu_times' will contain the cpu timing information of the scanner upon > I should have pointed this out earlier but forgot: could you update the con Done http://gerrit.cloudera.org:8080/#/c/8375/8/src/kudu/tserver/scanners.h@447 PS8, Line 447: > Nit: should be a space between ) and { Done http://gerrit.cloudera.org:8080/#/c/8375/8/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/8375/8/src/kudu/tserver/tablet_service.cc@699 PS8, Line 699: CpuTimes* cpu_times() { > Nit: for simple accessors like this you can just call it "cpu_times()". See Done http://gerrit.cloudera.org:8080/#/c/8375/8/src/kudu/tserver/tablet_service.cc@1622 PS8, Line 1622: metrics->set_cfile_cache_miss_bytes( : context->trace()->metrics()->GetMetric(cfile::CFILE_CACHE_MISS_BYTES_METRIC_NAME)); : metrics->set_cfile_cache_hit_bytes( : context->trace()->metrics()->GetMetric(cfile::CFILE_CACHE_HIT_BYTES_METRIC_NAME)); : : metrics->set_bytes_read( : context->trace()->metrics()->GetMetric(SCANNER_BYTES_READ_METRIC_NAME)); > Nit: the continuation lines for these calls are indented too much. They sho Done -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 10 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2019 07:25:33 +0000 Gerrit-HasComments: Yes
