Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 11: Patch looks good but you've got some IWYU failures to address: 19:32:57 >>> Fixing #includes in '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/scanners.h' 19:32:57 @@ -61,7 +61,6 @@ 19:32:57 enum class ScanState; 19:32:57 struct ScanDescriptor; 19:32:57 struct ScannerMetrics; 19:32:57 -struct ScanRPCMetrics; 19:32:57 19:32:57 typedef std::shared_ptr<Scanner> SharedScanner; 19:32:57 19:32:57 >>> Fixing #includes in '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_service.h' 19:32:57 @@ -23,7 +23,6 @@ 19:32:57 19:32:57 #include "kudu/consensus/consensus.service.h" 19:32:57 #include "kudu/gutil/port.h" 19:32:57 -#include "kudu/tserver/scanners.h" 19:32:57 #include "kudu/tserver/tserver.pb.h" 19:32:57 #include "kudu/tserver/tserver_admin.service.h" 19:32:57 #include "kudu/tserver/tserver_service.service.h" 19:32:57 >>> Fixing #includes in '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_service.cc' 19:32:57 @@ -106,6 +106,7 @@ 19:32:57 #include "kudu/util/slice.h" 19:32:57 #include "kudu/util/status.h" 19:32:57 #include "kudu/util/status_callback.h" 19:32:57 +#include "kudu/util/stopwatch.h" 19:32:57 #include "kudu/util/trace.h" 19:32:57 #include "kudu/util/trace_metrics.h" -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 11 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 18 Nov 2019 05:21:53 +0000 Gerrit-HasComments: No
